Skip to content

Supporting Pimoroni Pico Plus2 #77859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

soburi
Copy link
Member

@soburi soburi commented Sep 1, 2024

@soburi soburi changed the title Supporting Pimoroni pico plus2 Supporting Pimoroni Pico Plus2 Sep 1, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 1, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_rpi_pico DNM This PR should not be merged (Do Not Merge) labels Sep 1, 2024
Supported Features
==================

The rpi_pico board configuration supports the following
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

board name as used by west with `` around it and board target, not configuration

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely rewritten, please check again.

};
};

clocks_default: clocks_default {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty can go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@soburi soburi force-pushed the pimoroni_pico_plus2 branch 3 times, most recently from 808ef8a to cf60d51 Compare September 6, 2024 18:26
@soburi soburi force-pushed the pimoroni_pico_plus2 branch 3 times, most recently from af1da91 to 8eadd4c Compare September 15, 2024 10:54
@soburi soburi added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Sep 16, 2024
@soburi soburi force-pushed the pimoroni_pico_plus2 branch 10 times, most recently from 86c14e5 to b43d605 Compare September 22, 2024 13:32
@soburi soburi force-pushed the pimoroni_pico_plus2 branch 3 times, most recently from 0a752ce to 40f7d5e Compare September 27, 2024 22:47
@soburi soburi force-pushed the pimoroni_pico_plus2 branch from 40f7d5e to 11c503c Compare November 9, 2024 08:14
@soburi soburi force-pushed the pimoroni_pico_plus2 branch from 6788c4c to d1f5e9b Compare February 15, 2025 05:45
@soburi soburi requested review from kartben, ajf58 and nordicjm February 15, 2025 06:17
@kartben kartben added this to the v4.2.0 milestone Feb 15, 2025
kartben
kartben previously approved these changes Feb 15, 2025
@@ -238,6 +238,11 @@ GPIO
* Renamed the device tree property ``off_val`` to ``off-val``.
* Renamed the device tree property ``on_val`` to ``on-val``.
* Renamed the ``compatible`` from ``ti,ads114s0x-gpio`` to :dtcompatible:`ti,ads1x4s0x-gpio`.
* To support the RP2350B, which has many pins, the RaspberryPi-GPIO configuration has
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.1 feature freeze is past

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into doc/releases/migration-guide-4.1.rst.

@soburi soburi force-pushed the pimoroni_pico_plus2 branch 2 times, most recently from a85d9dc to f65599f Compare February 18, 2025 22:40
@petejohanson
Copy link
Contributor

@soburi Did you intend to include the Renesas related commits in your recent push?

Looking forward to this change, since I'm planning to submit a board definition for the Adafruit Metro RP2350 which uses RP2350B. I've got it working mostly already, minus the GPIO changes, but would rather piggyback on this core work. Thanks!

@soburi
Copy link
Member Author

soburi commented Feb 19, 2025

@petejohanson

@soburi Did you intend to include the Renesas related commits in your recent push?

Oh! It's my bad.
I was working on both in parallel so I made a mistake. Thank you for pointing that out.
I fix it ASAP.

@soburi soburi force-pushed the pimoroni_pico_plus2 branch from f65599f to 44b38e8 Compare February 19, 2025 20:31
soburi added 3 commits March 8, 2025 08:02
As the RP2350B has more than 32 GPIO pins,
we changed the configuration so that it is split into two ports.

To do this, we created a `raspberrypi,pico-gpio-port` node and
moved the previous `raspberrypi,pico-gpio-port` functions to it.

This became a child node of `raspberrypi,pico-gpio-port`, and
`raspberrypi,pico-gpio-port` will remain a gpio mapper.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
RP2350B is a rich IO variant in the RP2350 series.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Pinoroni Pico Plus2 is an RP2350B based board that has
more rich I/O, RAM, and Flash than the original Raspberry Pi Pico2.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
@soburi soburi force-pushed the pimoroni_pico_plus2 branch from 44b38e8 to 3977e2a Compare March 7, 2025 23:04
@soburi soburi requested review from nordicjm and kartben March 8, 2025 00:12
CONFIG_GPIO=y
CONFIG_RESET=y
CONFIG_SERIAL=y
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=150000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per other PR, should be in soc Kconfig, can be done in a later PR

@soburi
Copy link
Member Author

soburi commented Mar 10, 2025

@ThreeEights @ajf58
Could you check from GPIO perspective, please?

@kartben kartben assigned soburi and unassigned kartben Mar 10, 2025
@kartben
Copy link
Collaborator

kartben commented Mar 10, 2025

@soburi it looks like you may want to update the Raspberry Pi Pico Platforms section in MAINTAINERS.yml file

@soburi
Copy link
Member Author

soburi commented Mar 10, 2025

@kartben

@soburi it looks like you may want to update the Raspberry Pi Pico Platforms section in MAINTAINERS.yml file

It seems that many other boards need to be addressed besides this one, so I would like to address them all together in a separate PR.

@kartben kartben merged commit 70fc4a3 into zephyrproject-rtos:main Mar 10, 2025
22 checks passed
@soburi soburi deleted the pimoroni_pico_plus2 branch March 10, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants